Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder models tcgc #2759

Merged
merged 121 commits into from
Oct 18, 2024
Merged

Binder models tcgc #2759

merged 121 commits into from
Oct 18, 2024

Conversation

joheredi
Copy link
Member

@joheredi joheredi commented Aug 19, 2024

Summary of Changes in this PR

  1. use binder to manage model references
  2. deserializer support. fixes Fill in gaps for Deserialization #2625
  3. refactor of the operation helper in both serialization and deserialization. partially fix Serialization Followup work #2619 combine the previous serializeUtils/deserializer logic with serializer/deserializer.
  4. sdkPackage.models related adoption. Implement TCGC's SdkPackage types #2406
  5. client initialization adoption fixes Support client-level parameter defined @clientInitialization #2795
  6. use tcgc generated name for anonymous model
  7. rename RLC context name with tcgc client name.
  8. stop normalize the property name, fixes Should we cast property name automatically in modular? #2645
  9. refactor of all unit test to take options parameter instead of introducing long signature list.
  10. modular models for multiclient support. fixes revisit modular models generation in multi clients #2611
    a. generate one copy of models outside of the subclient folder of multi-client case.
    b. move operation options inside the api folder.

TCGC related issues

  1. [Bug]: should we have apiVersion lifted to client initialization if not all operation has this parameter? typespec-azure#1595
  2. [Bug]: EnumMember type as a clientDefaultValue? typespec-azure#1598
  3. [Bug]: Discriminated subtype is missing in models from sdkPackages  typespec-azure#1605
  4. [Bug]: fail to extract clientDefaultValue for apiVersion in server  typespec-azure#1608
  5. [Bug]: type existence check return false for the same union type in tcgc typespec-azure#1677
  6. [Bug]: usage is incorrect for lro initial response model typespec-azure#1678

@qiaozha qiaozha self-assigned this Aug 28, 2024
Copy link
Member

@MaryGao MaryGao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@qiaozha qiaozha mentioned this pull request Oct 17, 2024
Copy link
Member

@dgetu dgetu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@qiaozha qiaozha merged commit 30b5928 into Azure:main Oct 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants