Remove the hard-code for patch LRO #2583
Conversation
MaryGao
changed the title
| return context | ||
| .path("/test-runs/{testRunId}:stop", testRunId) | ||
| .path("/test-runs/{testRunId}:stopTestRun", testRunId) |
There was a problem hiding this comment.
issue tracked here: Azure/typespec-azure#1021
The referred path in RLC and modular is different and we could reproduce this in playground.
It should be a bug in TCGC or http lib.
- RLC
interface Foo {
@doc("Stop test run by test run Id.")
@operationId("LoadTestRun_StopTestRun")
stop is StandardResourceOperations.ResourceAction<FileInfo, {}, FileInfo, {}>;
}
The path we got is /files/{fileName}:stop.
- Modular
@client({
name: "LoadTestRunClient",
service: Contoso.WidgetManager,
})
interface TestRunOperations {
stopTestRun is Foo.stop;
}
The path we got is /files/{fileName}:stopTestRun.
MaryGao
changed the title
packages/typespec-test/test/loadtesting_modular/generated/typespec-ts/package.json
Show resolved
Hide resolved
...t/loadtesting_modular/generated/typespec-ts/src/testRunOperations/testRunOperationsClient.ts
Outdated
Show resolved
Hide resolved
| options: ListMetricDimensionValuesOptionalParams = { requestOptions: {} }, | ||
| ): PagedAsyncIterableIterator<DimensionValueList> { | ||
| ): Promise<DimensionValueList> { |
There was a problem hiding this comment.
Is changing from pagable to non-pagable a breaking? Also why would they have this change, it should be common to see changing from non-pagable to pagable, but should be uncommon in the reverse case?
There was a problem hiding this comment.
@weidongxu-microsoft Not sure you have more context. In the latest loadtesting spec,
- there is no LRO now
- listMetricDimensionValues is changed from ResourceList to Operation but becoming non-paging
There was a problem hiding this comment.
The LRO in Java is handwritten
https://github.com/Azure/azure-sdk-for-java/blob/main/sdk/loadtesting/azure-developer-loadtesting/src/main/java/com/azure/developer/loadtesting/LoadTestRunAsyncClient.java#L127-L146
from simple API like createOrUpdateTestRun getTestRun.
(from what I remember, the status in GET response etc. does not match Azure guideline and SDK core lib handling of LRO -- that was the api-version in main, this version in PR maybe different)
There was a problem hiding this comment.
The LRO change is expected and the paging change is waiting for the service team's reply, but I think we don't need to block this pr since this is service spec change. Let me offline confirm this.
fixes #2314
Previously there is some issues with getLroMetadata for PATCH method from TypeSpec. In the latest compiler version these issues are resolved and we need to remove these hard-codes.