Support modular paging #1996
Merged
Support modular paging #1996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaryGao
commented
Aug 29, 2023
...pespec-test/test/contentsafety_modular/generated/typespec-ts/review/ai-content-safety.api.md
Outdated
Show resolved
Hide resolved
MaryGao
commented
Aug 29, 2023
MaryGao
commented
Nov 21, 2023
MaryGao
commented
Nov 21, 2023
packages/typespec-test/test/batch_modular/generated/typespec-ts/src/api/pagingHelpers.ts
Outdated
Show resolved
Hide resolved
qiaozha
approved these changes
Nov 22, 2023
|
Jeff's approval: |
deyaaeldeen
reviewed
Nov 23, 2023
...ages/typespec-test/test/contentsafety_modular/generated/typespec-ts/src/api/pagingHelpers.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
reviewed
Nov 23, 2023
...ges/typespec-test/test/contentsafety_modular/generated/typespec-ts/src/models/pagingTypes.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
reviewed
Nov 23, 2023
...ges/typespec-test/test/contentsafety_modular/generated/typespec-ts/src/models/pagingTypes.ts
Outdated
Show resolved
Hide resolved
deyaaeldeen
reviewed
Nov 23, 2023
packages/typespec-test/test/batch_modular/generated/typespec-ts/src/models/pagingTypes.ts
Outdated
Show resolved
Hide resolved
…pespec-ts/src/models/pagingTypes.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
…pespec-ts/src/models/pagingTypes.ts Co-authored-by: Deyaaeldeen Almahallawi <[email protected]>
deyaaeldeen
approved these changes
Nov 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1856
This is the initial version for modular paging. The whole discussion is under above issue.
We build paging helpers and types in SDK side and keep the similar interface with HLC paging with slightly differences:
maxpagesizein PageSettingTPage & { continuationToken?: string; }Advanced paging cases will be covered in another issue #2134.