Update constants.json #373
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iscai-msft
reviewed
Mar 22, 2022
swagger/constants.json
Outdated
| @@ -658,8 +658,7 @@ | |||
| "in": "header", | |||
| "required": true, | |||
| "type": "boolean", | |||
| "description": "Constant header property on the client that is a required parameter for operation 'constants_putClientConstants'", | |||
| "enum": [true] | |||
| "description": "Constant header property on the client that is a required parameter for operation 'constants_putClientConstants'" | |||
There was a problem hiding this comment.
@msyyc having "enum": [true] is the point of the test because that is how we define a constant in the swagger: by having a single value enum. It's confusing definitely, and we have had discussions about this swagger design, but this is how we still specify constants, and in this test we want to test a header param with constant value true. So I think the test should stay the way it currently is.
For more info, you can see this doc, specifically the third bullet point
There was a problem hiding this comment.
I will add x-ms-enum: false to keep the test compatible
|
merge the content with #368 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.