removed azure- prefix from ua if there #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmazuel
reviewed
Mar 26, 2020
| @@ -44,11 +44,17 @@ def _config_imports(async_mode: bool) -> FileImport: | |||
| # file_import.add_from_import("azure.core.credentials", "TokenCredential", ImportType.AZURECORE) | |||
| return file_import | |||
|
|
|||
| package_name = self.code_model.options['package_name'] | |||
| if package_name and package_name.startswith("azure-"): | |||
| package_name = package_name.replace("azure-", "", 1) | |||
There was a problem hiding this comment.
Slice syntax is usually more common
package_name = package_name[len("azure-"):]
iscai-msft
added a commit
that referenced
this pull request
Mar 26, 2020
…into add_async_multiapi_client * 'autorestv3' of https://github.com/Azure/autorest.python: switiching version.py -> _version.py if we want to keep version file (#522) Update changelog (#526) removed azure- prefix from ua if there (#523) Declare kwargs reserved (#525) updating to m4 4.12.276 (#524) Add self as reserved keyword (#315) Freeze master to 2.7.8 (#258) No async flag (#95)
iscai-msft
added a commit
that referenced
this pull request
Mar 30, 2020
…into autorestv3 * 'autorestv3' of https://github.com/Azure/autorest.python: removed azure- prefix from ua if there (#523) Add self as reserved keyword (#315) Freeze master to 2.7.8 (#258) No async flag (#95)
iscai-msft
added a commit
that referenced
this pull request
Apr 1, 2020
…into generated_code_mypy_fixes * 'autorestv3' of https://github.com/Azure/autorest.python: ChangeLog updated to testserver .19 (#529) Fix default value enum py3 (#532) switiching version.py -> _version.py if we want to keep version file (#522) Update changelog (#526) removed azure- prefix from ua if there (#523) Declare kwargs reserved (#525) updating to m4 4.12.276 (#524) Add self as reserved keyword (#315) Freeze master to 2.7.8 (#258) No async flag (#95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #479
