use alternative way to generate assemblyinfo.cs #1387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isra-fel
requested changes
Oct 10, 2024
isra-fel
approved these changes
Oct 10, 2024
VeryEarly
added a commit
that referenced
this pull request
Oct 11, 2024
* use alternative way to generate assemblyinfo.cs * disable generate assemblyinfo by dotnet * forgot await * Update powershell/generators/csproj.ts * check if assemblyinfopath --------- Co-authored-by: Yeming Liu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Oct 14, 2024
* use alternative way to generate assemblyinfo.cs * disable generate assemblyinfo by dotnet * forgot await * Update powershell/generators/csproj.ts * check if assemblyinfopath --------- Co-authored-by: Yeming Liu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Oct 14, 2024
* use alternative way to generate assemblyinfo.cs * disable generate assemblyinfo by dotnet * forgot await * Update powershell/generators/csproj.ts * check if assemblyinfopath --------- Co-authored-by: Yeming Liu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Oct 14, 2024
* use alternative way to generate assemblyinfo.cs * disable generate assemblyinfo by dotnet * forgot await * Update powershell/generators/csproj.ts * check if assemblyinfopath --------- Co-authored-by: Yeming Liu <[email protected]>
VeryEarly
added a commit
that referenced
this pull request
Oct 15, 2024
* generate assemblyinfo.cs for azure (#1384) * add assemblyinfo to csproj * insert header for assemblyinfo * move insert header after compilation * do not insert header if assemblyinfopaht not present * fix * remove write-host for insert license * use alternative way to generate assemblyinfo.cs (#1387) * use alternative way to generate assemblyinfo.cs * disable generate assemblyinfo by dotnet * forgot await * Update powershell/generators/csproj.ts * check if assemblyinfopath --------- Co-authored-by: Yeming Liu <[email protected]> * cherry-pick assemblyinfo changes from v4, upgrade to 3.0.520 --------- Co-authored-by: Yeming Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
original PR: #1376
reverted by: #1380
then: #1384
in #1384 I used msbuild to generate Assemblyinfo, the syntax does not compatible with dotnet 6 and msbuild 17.7. To avoid unexpected compatible issues, use template to generate assemblyinfo instead.