Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add subtype at import list #396

Closed
wants to merge 1 commit into from

Conversation

ChenTanyi
Copy link

@ChenTanyi
Copy link
Author

@ChenTanyi
Copy link
Author

@ChenTanyi
Copy link
Author

@jianghaolu could you review this PR? Thanks.

@jianghaolu
Copy link
Contributor

Can you help me understand why the sub types need to imported? They should all be the in the same models package?

@ChenTanyi
Copy link
Author

ChenTanyi commented Nov 12, 2019

@jianghaolu in the sdk automation I point to test-repo-billy/azure-rest-api-specs#378 (datamigration/resource-manager/v2018_07_15_preview), there is compilation error due to subtype import error. The json property use subtype, but the subtype has not been imported. This is why I add the subtype import to fix the error.

@ChenTanyi ChenTanyi closed this Jun 23, 2020
@ChenTanyi ChenTanyi deleted the import_subtype branch June 23, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants