Support concurrent usage of fake pager and poller APIs #995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a pager/poller state machine per combination of HTTP verb and URL path so that API calls for different resources don't overlap. Bump version number in preparation for release.
Don't use the HTTP verb when stashing the state machine as it can change for an LRO depending on the operation.
jhendrixMSFT
commented
Jul 18, 2023
| } | ||
|
|
||
| func (p *tracker[T]) key(req *http.Request) string { | ||
| path := req.URL.Path |
There was a problem hiding this comment.
This assumes that path will be unique per invocation. Probably always true for ARM, but is it universally true? I'm thinking perhaps a POST for the same path but with differing query parameters.
There was a problem hiding this comment.
Unfortunately we don't propagate query parameters when creating the fake poller or injecting next links for paged operations. Will fix this in the next azcore beta.
chlowell
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a pager/poller state machine per combination of HTTP verb and URL path so that API calls for different resources don't overlap. Bump version number in preparation for release.
Fixes the issue reported in Azure/azure-sdk-for-go#16613 (comment)