Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): no test case will throw error #5032

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

archerzz
Copy link
Member

@archerzz archerzz commented Sep 2, 2024

Description

vitest will throw error by default if no test is found. To suppress this error, we need to add --passWithNoTests to the options.

An alternative is to set up a vitest.config file and define that option. That's probably overdone since emitter codes are no longer maintained here.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

`vitest` will throw error by default if no test is found. To suppress this error, we need to add `--passWithNoTests` to the options.

An alternative is to set up a `vitest.config` file and define that option. That's probably overdone since emitter codes are no longer maintained here.
@archerzz
Copy link
Member Author

archerzz commented Sep 2, 2024

@archerzz archerzz merged commit f7828c6 into Azure:feature/v3 Sep 2, 2024
24 checks passed
@archerzz archerzz deleted the build/fix-no-test-error branch September 2, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants