Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update name transformer #1978

Merged
merged 6 commits into from
Feb 17, 2022
Merged

Update name transformer #1978

merged 6 commits into from
Feb 17, 2022

Conversation

ArcturusZhang
Copy link
Member

@ArcturusZhang ArcturusZhang commented Feb 15, 2022 •
edited
Loading

Description

In the previous implementation, we did not transform the name of choice values. This PR also transforms that.

Checklist

To ensure a quick review and merge, please ensure:

  • The PR has a understandable title and description explaining the why and what.
  • The PR is opened in draft if not ready for review yet.
    • If opened in draft, please allocate sufficient time (24 hours) after moving out of draft for review
  • The branch is recent enough to not have merge conflicts upon creation.

Ready to Land?

  • Build is completely green
    • Submissions with test failures require tracking issue and approval of a CODEOWNER
  • At least one +1 review by a CODEOWNER
  • All -1 reviews are confirmed resolved by the reviewer
    • Override/Marking reviews stale must be discussed with CODEOWNERS first

@ArcturusZhang ArcturusZhang mentioned this pull request Feb 15, 2022
Merged
@ArcturusZhang ArcturusZhang reopened this Feb 16, 2022
@ArcturusZhang ArcturusZhang enabled auto-merge (squash) February 16, 2022 04:11
auto-merge was automatically disabled February 16, 2022 07:52

Pull request was closed

@ArcturusZhang ArcturusZhang reopened this Feb 16, 2022
@ArcturusZhang ArcturusZhang reopened this Feb 17, 2022
@ArcturusZhang ArcturusZhang enabled auto-merge (squash) February 17, 2022 00:53
@ArcturusZhang ArcturusZhang merged commit b974274 into Azure:feature/v3 Feb 17, 2022
@ArcturusZhang ArcturusZhang deleted the update-name-transformer branch February 17, 2022 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexanderSher AlexanderSher AlexanderSher left review comments

@Yao725 Yao725 Yao725 approved these changes

@allenjzhang allenjzhang Awaiting requested review from allenjzhang

@m-nash m-nash Awaiting requested review from m-nash

@ShivangiReja ShivangiReja Awaiting requested review from ShivangiReja

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ArcturusZhang @AlexanderSher @Yao725