-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix security warning. #643
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -31,11 +31,7 @@ | |
--> | ||
|
||
<module name="Checker"> | ||
<module name="SuppressWithNearbyCommentFilter"> | ||
<property name="commentFormat" value="CHECKSTYLE IGNORE (\w+) FOR NEXT (\d+) LINE"/> | ||
<property name="checkFormat" value="$1"/> | ||
<property name="influenceFormat" value="$2"/> | ||
</module> | ||
|
||
<module name="SuppressionFilter"> | ||
<property name="file" value="${samedir}/suppressions.xml"/> | ||
<property name="optional" value="true"/> | ||
|
@@ -84,11 +80,17 @@ | |
</module> | ||
|
||
<module name="TreeWalker"> | ||
<module name="SuppressWithNearbyCommentFilter"> | ||
<property name="commentFormat" value="CHECKSTYLE IGNORE (\w+) FOR NEXT (\d+) LINE"/> | ||
<property name="checkFormat" value="$1"/> | ||
<property name="influenceFormat" value="$2"/> | ||
</module> | ||
<!-- Checks for Javadoc comments. --> | ||
<!-- See http://checkstyle.sf.net/config_javadoc.html --> | ||
|
||
<module name="JavadocMethod"> | ||
<property name="scope" value="public"/> | ||
<property name="allowMissingParamTags" value="true"/> | ||
</module> | ||
<module name="JavadocType"> | ||
<property name="scope" value="public"/> | ||
|
@@ -173,8 +175,6 @@ | |
<!-- See http://checkstyle.sf.net/config_modifiers.html --> | ||
<module name="ModifierOrder"/> | ||
<module name="RedundantModifier"/> | ||
<module name="FileContentsHolder"/> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this removed? From the docs it seems this is needed if used in conjunction with
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to this release note: https://checkstyle.sourceforge.io/releasenotes.html#Release_8.2, this is not necessary again after version 8.2. Here we use 8.24 to make it consist with the latest setup on the azure-sdk-for-java-repo. |
||
|
||
|
||
<!-- Checks for blocks. You know, those {}'s --> | ||
<!-- See http://checkstyle.sf.net/config_blocks.html --> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are too many warnings about violation of this rule. Given this, I suppress this temporarily. If the security work is not urgent, I would like to fix the issue on generator and then on the fluent code base.