Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #612 #614

Merged
merged 2 commits into from
May 29, 2019
Merged

Fix for issue #612 #614

merged 2 commits into from
May 29, 2019

Conversation

praries880
Copy link
Contributor

Fix for issue #612

@praries880 praries880 added the bug label May 24, 2019
@praries880 praries880 requested a review from jianghaolu May 24, 2019 17:40
@praries880 praries880 self-assigned this May 24, 2019
@praries880 praries880 mentioned this pull request May 24, 2019
Open
@praries880
Copy link
Contributor Author

@jianghaolu can you kindly review this PR :)

@praries880 praries880 merged commit 0402902 into master May 29, 2019
v-jizhang
v-jizhang reviewed May 29, 2019
View reviewed changes
Copy link

@v-jizhang v-jizhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

p.setCodec(mapper) have side effect, it set the codec. What if the parser p is used later by the caller with the newly added codec(which is irrelevant to the caller)?. For example, if there is another property follows "error". Can it still reads?

@lmazuel lmazuel deleted the 612_fix branch June 17, 2019 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-jizhang v-jizhang v-jizhang left review comments

@jianghaolu jianghaolu jianghaolu approved these changes

Assignees

@praries880 praries880

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@praries880 @jianghaolu @v-jizhang