Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The client runtime does not support dates as value in Retry-After #455

Closed
johanste opened this issue Aug 1, 2018 · 3 comments
Closed

The client runtime does not support dates as value in Retry-After #455

johanste opened this issue Aug 1, 2018 · 3 comments

Comments

@johanste
Copy link
Member

johanste commented Aug 1, 2018 •
edited
Loading

this code tries to parse the value of the Retry-After as an integer/number of seconds. Per the spec, the value can also be provided as a http-date.
@RikkiGibson
Copy link
Member

Would like to make a few changes here:

  • Handle both "seconds" and "date" case in Retry-After header
  • Drop the regex search in the response content if at all possible
  • Don't worry about which subscription is being throttled--instead have each operation handle its 429s independently

@johanste
Copy link
Member Author

johanste commented Aug 1, 2018

+1 on each operation handle its 429s independently. The cause of the 429s can be independent (too many calls to compute should not throttle calls to networking)

jianghaolu added a commit to jianghaolu/autorest-clientruntime-for-java that referenced this issue Aug 6, 2018
@jianghaolu
[Azure#455] Support rfc 1123 retry-after header
4238a0f
jianghaolu added a commit that referenced this issue Aug 7, 2018
@jianghaolu
Issue fixes (#463)
690042a 
* [Resolves #458] timeout adjust: read 120 conn 60

* [Resolves #461] Support log analytics and app insights endpoints

* Fix timeout for RestClient.newBuilder()

* [#455] Support rfc 1123 retry-after header

* Add US GOV log analytics endpoint

* Up adal and commons-codec version

* [Resolves #440] Allow setting max retry for MSI creds
@jianghaolu
Copy link
Contributor

Supported via #463

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jianghaolu @RikkiGibson @johanste