feat: Set EtcdDiskSizeGB max default size to 1023 if target platform is Azure Stack #1558
Conversation
| @@ -233,9 +233,19 @@ func (cs *ContainerService) setOrchestratorDefaults(isUpgrade, isScale bool) { | |||
| if "" == a.OrchestratorProfile.KubernetesConfig.EtcdDiskSizeGB { | |||
| switch { | |||
| case a.TotalNodes() > 20: | |||
| a.OrchestratorProfile.KubernetesConfig.EtcdDiskSizeGB = DefaultEtcdDiskSizeGT20Nodes | |||
| if a.IsAzureStackCloud() { | |||
| // Currently on Azure Stack max size of managed disk size is 1023GB. | |||
There was a problem hiding this comment.
@rjaini do we know how much disk is required for 20 + nodes? The cluster will be not usable if the disc is out of space.
Another alternative is to limit the total count of agent nodes.
And we should raise the request to Disk RP on Azure Stack to support larger size of disk.
There was a problem hiding this comment.
There was a problem hiding this comment.
Matt is out on vacation but see Azure/acs-engine#2435 for context.
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
+ Coverage 75.86% 75.86% +<.01%
==========================================
Files 128 128
Lines 18314 18320 +6
==========================================
+ Hits 13893 13899 +6
Misses 3636 3636
Partials 785 785 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #1558 +/- ##
==========================================
+ Coverage 75.86% 75.86% +<.01%
==========================================
Files 128 128
Lines 18314 18320 +6
==========================================
+ Hits 13893 13899 +6
Misses 3636 3636
Partials 785 785 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, honcao, rjaini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reason for Change:
Azure Stack only supports max disk size to be 1023GB. So in case when the number of nodes increases
we cant increase the size to 1024 or 2048GB.
Issue Fixed:
Fixes #1557
Requirements:
Notes: