Skip to content
This repository has been archived by the owner on Oct 24, 2023. It is now read-only.

feat: add support for Kubernetes v1.15.0-alpha.1 #1140

Merged
merged 4 commits into from
Apr 30, 2019

Conversation

mboersma
Copy link
Member

Reason for Change:

See https://github.com/kubernetes/kubernetes/blob/master/CHANGELOG-1.15.md#v1150-alpha1

Issue Fixed:

Requirements:

  • Windows artifacts uploaded to acsmirror blob store
  • uses conventional commit messages
  • includes documentation
  • adds unit tests
  • tested upgrade from previous version

Notes:

@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #1140 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   74.71%   74.76%   +0.04%     
==========================================
  Files         129      129              
  Lines       18387    18422      +35     
==========================================
+ Hits        13738    13773      +35     
  Misses       3856     3856              
  Partials      793      793

@mboersma mboersma changed the title feat: add support for Kubernetes v1.15.0-alpha.1 [WIP] feat: add support for Kubernetes v1.15.0-alpha.1 Apr 24, 2019
@zhiweiv
Copy link
Contributor

zhiweiv commented Apr 25, 2019

Metrics server 0.3.x doesn’t work with Windows nodes, see kubernetes/kubernetes#75934.

Besides, the parameters are changed in 0.3.x, you should update the kubernetesmasteraddons-metrics-server-deployment.yaml.

@mboersma mboersma force-pushed the add-k8s-v1.15.0-alpha.1 branch from fe4ffa9 to 7c53f53 Compare April 29, 2019 17:23
@mboersma mboersma force-pushed the add-k8s-v1.15.0-alpha.1 branch from 7c53f53 to 35e3ac6 Compare April 29, 2019 18:16
@mboersma
Copy link
Member Author

update the kubernetesmasteraddons-metrics-server-deployment.yaml

Let's do that as a separate task: #1172.

@mboersma mboersma changed the title [WIP] feat: add support for Kubernetes v1.15.0-alpha.1 feat: add support for Kubernetes v1.15.0-alpha.1 Apr 29, 2019
@jackfrancis
Copy link
Member

/lgtm

@acs-bot acs-bot added the lgtm label Apr 30, 2019
@acs-bot acs-bot merged commit d55ddca into Azure:master Apr 30, 2019
@acs-bot
Copy link

acs-bot commented Apr 30, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jackfrancis, mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jackfrancis,mboersma]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mboersma mboersma deleted the add-k8s-v1.15.0-alpha.1 branch April 30, 2019 16:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants