-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move basic e2e tests to new e2e and add upgrade scenario #95
Conversation
…upgrade story now)
Pull Request Test Coverage Report for Build 6164919630
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very much left to go through but wanted to post these before the weekend.
excited to look through the rest!
/ok-to-test sha=b43d23b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm for the most part, only request is if we can clean up test setup/running suites with different configs (even if that means, for instance, adding operator deploy scenario as an operator config or something else to consolidate information there)
"github.com/Azure/aks-app-routing-operator/testing/e2e/manifests" | ||
) | ||
|
||
type cfgBuilder struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
absolutely love how thorough the documentation/comments have been throughout this PR - would you mind adding some brief descriptions here too? I think this is definitely a great practice that we should begin enforcing on future PRs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what exactly are you looking to be documented here? Tried to make it as self documenting as possible with the type system
|
||
type ordered []testsWithRunInfo | ||
|
||
type testsWithRunInfo struct { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are lots of types here and it's a bit confusing to keep track of all the casting/movement of information which I imagine will make debugging a bit difficult - is there any way we can clean this up? This was mostly inspired by all the different types used in testing/e2e/tests/run.go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
realistically I'm not sure how exactly this will take place but happy to chat about what my specific pain points are - just a lot of mixes between lists and types that contain lists, similar names, etc etc - I just feel like it can be cleaner/that we can consolidate a lot of the information that is repeatedly moving around
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it's definitely a lot but using more times makes this simpler in this case. Using separate types to move information up means we can take away information making it easier to develop with.
If you can think of a specific way to improve this I'm happy to implement that in the future but this is the best I have for now.
// group tests by operator configuration | ||
operatorCfgSet := make(map[manifests.OperatorConfig][]testWithConfig) | ||
for _, test := range operatorVersionSet[version] { | ||
operatorCfgSet[test.config] = append(operatorCfgSet[test.config], test) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
re: my comment in types... this is a lot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving changes per discussion/call
Description
What's left for e2e
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally. You can too by running
Checklist: