Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new e2e testing framework #90

Merged
merged 11 commits into from
Aug 31, 2023
Merged

Add new e2e testing framework #90

merged 11 commits into from
Aug 31, 2023

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Aug 29, 2023

Description

Fixes how the operator looks for the self deploy by adding a new field for that.

Finishes another phase of the e2e testing framework. This framework isn't used yet but will be fully migrated to in the future.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

pkg/config/config.go Outdated Show resolved Hide resolved
testing/e2e/clients/aks.go Outdated Show resolved Hide resolved
testing/e2e/clients/aks.go Show resolved Hide resolved
@coveralls
Copy link
Collaborator

coveralls commented Aug 30, 2023

Pull Request Test Coverage Report for Build 6029580666

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.942%

Totals Coverage Status
Change from base Build 6016878580: 0.02%
Covered Lines: 1866
Relevant Lines: 2098

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=144e60d

Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just some feedback about file naming/placement but lgtm otherwise

testing/e2e/suites/suites.go Outdated Show resolved Hide resolved
testing/e2e/tests/types.go Outdated Show resolved Hide resolved
testing/e2e/tests/test.go Show resolved Hide resolved
@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=144e60d

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=144e60d

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=3736c49

@OliverMKing OliverMKing merged commit b4375a4 into Azure:main Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants