Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ingress-nginx v1.8.1 #89

Merged
merged 9 commits into from
Aug 31, 2023
Merged

Update to ingress-nginx v1.8.1 #89

merged 9 commits into from
Aug 31, 2023

Conversation

gambtho
Copy link
Contributor

@gambtho gambtho commented Aug 28, 2023

Description

Move to latest nginx version
https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.8.1

Includes addition of role/role-binding for the app-routing-system namespace, and reduction of privileges for the cluster role

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • unit tests
  • make all-tests
  • manual tests - existing service before and after upgrade with continuous traffic

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Aug 28, 2023

Pull Request Test Coverage Report for Build 6039182995

  • 115 of 115 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 89.469%

Totals Coverage Status
Change from base Build 6038401621: 0.5%
Covered Lines: 1971
Relevant Lines: 2203

💛 - Coveralls

@gambtho gambtho changed the title Move to latest nginx version Update to ingress-nginx v1.8.1 Aug 28, 2023
@gambtho gambtho changed the title Update to ingress-nginx v1.8.1 WIP: Update to ingress-nginx v1.8.1 Aug 28, 2023
@gambtho gambtho force-pushed the thgamble/nginxupdate branch from 04c3e5e to 5d4847d Compare August 29, 2023 21:20
@gambtho gambtho changed the title WIP: Update to ingress-nginx v1.8.1 Update to ingress-nginx v1.8.1 Aug 30, 2023
@gambtho gambtho force-pushed the thgamble/nginxupdate branch from dd2843c to 7c174f4 Compare August 30, 2023 14:12
pkg/manifests/nginx.go Outdated Show resolved Hide resolved
pkg/manifests/nginx.go Outdated Show resolved Hide resolved
@gambtho gambtho force-pushed the thgamble/nginxupdate branch from cc389d5 to ccf9f88 Compare August 30, 2023 21:01
@jaiveerk jaiveerk merged commit 4ef34bd into main Aug 31, 2023
@gambtho gambtho deleted the thgamble/nginxupdate branch September 6, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants