Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add controller logging format to managed controllers #86

Merged
merged 1 commit into from
Aug 25, 2023
Merged

add controller logging format to managed controllers #86

merged 1 commit into from
Aug 25, 2023

Conversation

OliverMKing
Copy link
Collaborator

Description

We have two kinds of controllers in app routing. For controllers that are created completely through controller manager they have an internal logging format where they add a few additional fields. We need to add our controller fields to this logger when creating these controllers or else they will be missing fields we want on all controller logs.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually and with e2e and unit

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=7a0d75

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=7a07d75

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 5968756965

  • 22 of 50 (44.0%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.6%) to 88.921%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/service/ingress_reconciler.go 0 6 0.0%
pkg/controller/keyvault/ingress_secret_provider_class.go 0 10 0.0%
pkg/controller/controllername/controllername.go 0 12 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/service/ingress_reconciler.go 1 84.31%
Totals Coverage Status
Change from base Build 5968033748: -0.6%
Covered Lines: 1862
Relevant Lines: 2094

💛 - Coveralls

Copy link
Contributor

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Will be nice to have this roll out for updated logging

@OliverMKing OliverMKing merged commit e4e5027 into Azure:main Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants