-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add controller name interface to all controllers #85
add controller name interface to all controllers #85
Conversation
/ok-to-test sha=dc2e802 |
Pull Request Test Coverage Report for Build 5966036453
💛 - Coveralls |
/ok-to-test sha=d397a9a |
/ok-to-test sha=d9ef721 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very clean, lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Description
Adds controller name interface to all controllers. Allows for us to enforce consistent logging and metric naming for all controllers. Will be useful for alerting based on prometheus especially. If an alert fires we can attach an automatically generated query that can search relevant controller logs for that alert.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit and e2e tested
Checklist: