Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add controller name interface to all controllers #85

Merged
merged 4 commits into from
Aug 24, 2023
Merged

add controller name interface to all controllers #85

merged 4 commits into from
Aug 24, 2023

Conversation

OliverMKing
Copy link
Collaborator

Description

Adds controller name interface to all controllers. Allows for us to enforce consistent logging and metric naming for all controllers. Will be useful for alerting based on prometheus especially. If an alert fires we can attach an automatically generated query that can search relevant controller logs for that alert.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit and e2e tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=dc2e802

@coveralls
Copy link
Collaborator

coveralls commented Aug 24, 2023

Pull Request Test Coverage Report for Build 5966036453

  • 28 of 35 (80.0%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 89.537%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/dns/external_dns.go 1 2 50.0%
pkg/controller/controllername/controllername.go 12 18 66.67%
Totals Coverage Status
Change from base Build 5963965196: -0.2%
Covered Lines: 1857
Relevant Lines: 2074

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=d397a9a

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=d9ef721

Copy link
Contributor

@Marcus-Hines Marcus-Hines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very clean, lgtm

Copy link
Contributor

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OliverMKing OliverMKing merged commit bff71e0 into Azure:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants