Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ControllerName struct, and test cases #84

Merged
merged 28 commits into from
Aug 24, 2023
Merged

Conversation

Marcus-Hines
Copy link
Contributor

@Marcus-Hines Marcus-Hines commented Aug 22, 2023

Description

Continuing to enforce Prometheus best practices for metics. Adding a struct that ensures naming conventions are upheld, and uniformity exists between metric naming and logger

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator

unit tests are failing right now

OliverMKing
OliverMKing previously approved these changes Aug 23, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 23, 2023

Pull Request Test Coverage Report for Build 5956001568

  • 21 of 21 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+3.8%) to 89.797%

Totals Coverage Status
Change from base Build 5929363980: 3.8%
Covered Lines: 1857
Relevant Lines: 2068

💛 - Coveralls

OliverMKing
OliverMKing previously approved these changes Aug 23, 2023
OliverMKing
OliverMKing previously approved these changes Aug 23, 2023
OliverMKing
OliverMKing previously approved these changes Aug 23, 2023
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=83bd476

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=0e5659b

@jaiveerk jaiveerk merged commit e4d9c12 into Azure:main Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants