Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump test coverage up to at least 80% where possible #82

Merged
merged 4 commits into from
Aug 21, 2023

Conversation

NickKeller
Copy link
Member

Description

Bump test coverage to at least 80% where possible

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Test Coverage increase

How Has This Been Tested?

  • Added unit tests

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Aug 17, 2023

Pull Request Test Coverage Report for Build 5904359165

  • 0 of 54 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 86.035%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/testutils/fakemanager.go 0 54 0.0%
Totals Coverage Status
Change from base Build 5871209609: -0.02%
Covered Lines: 1842
Relevant Lines: 2141

💛 - Coveralls

Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small questions/ideas but lgtm overall

pkg/controller/controller_test.go Outdated Show resolved Hide resolved
pkg/controller/keyvault/event_mirror_test.go Show resolved Hide resolved
@OliverMKing
Copy link
Collaborator

/ok-to-test sha=e21d3a

@OliverMKing OliverMKing merged commit 4a0ab0f into Azure:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants