add deploy e2e tester image functionality to new e2e #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5868909783
💛 - Coveralls |
davidgamero
reviewed
Aug 11, 2023
| // https://github.com/Azure/azure-cli/blob/5f9a8fa25cc1c980ebe5e034bd419c95a1c578e2/src/azure-cli/azure/cli/command_modules/acr/build.py#L25 | ||
| cmd := exec.Command("az", "acr", "build", "--registry", a.name, "--image", imageName, ".") | ||
| cmd.Stdout = newLogWriter(lgr, "building and pushing acr image: ", nil) | ||
| cmd.Stderr = newLogWriter(lgr, "building and pushing acr image: ", to.Ptr(slog.LevelError)) |
There was a problem hiding this comment.
love to see the slog package in the wild
There was a problem hiding this comment.
And the slog package loves to see you
There was a problem hiding this comment.
slog be with you
jaiveerk
requested changes
Aug 14, 2023
|
/ok-to-test sha=d8bfea1 |
bfoley13
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part 2 of some e2e improvements. This is targeting a new e2e framework and does not impact the current e2e environment (yet). The plan is to move all the e2e tests over to this new framework in the next pr and replace the existing one with this new one.
This change makes it so we can easily deploy an e2e testing image to each testing infrastructure cluster. This e2e testing image must run inside clusters to accommodate all cluster options (namely private clusters).
Additionally, this PR sets up the ability for e2e tests to be run in separate GitHub jobs.
We want e2e tests to run in a separate job for each phase with separate jobs for each infrastructure. This is to ensure that if we need to manually retry a test it it's simple and we don't need to retry everything. It also makes it easy to detect errors.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Locally
Checklist: