Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests #77

Merged
merged 15 commits into from
Aug 10, 2023
Merged

Added unit tests #77

merged 15 commits into from
Aug 10, 2023

Conversation

rsamigullin
Copy link
Contributor

@rsamigullin rsamigullin commented Aug 4, 2023

Description

Improved code coverage for aks-app-routing-operator

Fixes # https://msazure.visualstudio.com/CloudNativeCompute/_workitems/edit/24677451/
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes - Added more unit tests
Provide instructions so we can reproduce - run go test./...

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@rsamigullin rsamigullin changed the title added unit tests Added unit tests Aug 4, 2023
@rsamigullin rsamigullin changed the title Added unit tests [WIP]Added unit tests Aug 4, 2023
@coveralls
Copy link
Collaborator

coveralls commented Aug 7, 2023

Pull Request Test Coverage Report for Build 5823298761

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+9.3%) to 87.445%

Totals Coverage Status
Change from base Build 5798948450: 9.3%
Covered Lines: 1790
Relevant Lines: 2047

💛 - Coveralls

@rsamigullin rsamigullin changed the title [WIP]Added unit tests Added unit tests Aug 7, 2023
@jaiveerk
Copy link
Collaborator

jaiveerk commented Aug 7, 2023

/ok-to-test sha=c1edcf5

jaiveerk
jaiveerk previously approved these changes Aug 7, 2023
Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor changes, lgtm otherwise

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=f1c345f

jaiveerk
jaiveerk previously approved these changes Aug 9, 2023
Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock merging

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=e6ef8db

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=e8f17b5

@OliverMKing OliverMKing merged commit 4200157 into Azure:main Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants