Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add gocover checks for PR's #74

Merged
merged 41 commits into from
Jul 28, 2023
Merged

Add gocover checks for PR's #74

merged 41 commits into from
Jul 28, 2023

Conversation

hsubramanianaks
Copy link
Collaborator

@hsubramanianaks hsubramanianaks commented Jul 28, 2023 •
edited
Loading

Description

This PR is to add gocover and coverall- code coverage check for unit tests for any PR opened against main branch.

Type of change: Feature

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

  • Github actions via forked repo

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

hsubramanianaks and others added 30 commits July 25, 2023 23:59
@hsubramanianaks
updat github rest name
037bd2f
@hsubramanianaks
download asset url and run go cover
1e5fd2d
@hsubramanianaks
correct result-encoding
cd66fd7
@hsubramanianaks
change it to steps
a05df0a
@hsubramanianaks
try with bash and wget
090d555
@hsubramanianaks
add echo statement to verify asset url
2636d1f
@hsubramanianaks
remove trim from asset url
cfd604e
@hsubramanianaks
try as json result encoding
ecdb5fa
@hsubramanianaks
change the js filter condition
8521041
@hsubramanianaks
correct the cover profile syntax err
4386f27
@hsubramanianaks
Go cover (#1)
965b8e7
@hsubramanianaks
Go cover (#2)
0aa9794
@hsubramanianaks
Merge branch 'main' of github.com:hsubramanianaks/aks-app-routing-ope…
bf69c83 
…rator
@hsubramanianaks
upload coverage html report
f47f79c
@hsubramanianaks
upload artifact to v3
b532e39
@hsubramanianaks
bumping setup go action to remove deprecated warnings
d22ec6f
@hsubramanianaks
change coverage report name
c8b161d
@hsubramanianaks
change it back to workflow call and separate jobs
6d33196
@hsubramanianaks
try with id-token write for e2e
218a99d
@hsubramanianaks
remove dependson from unit test
1eeb92a
@hsubramanianaks
update gocover full to diff check
0e1cb8a
@hsubramanianaks
add checkout and setup go step.
810e989
@hsubramanianaks
correct syntax error
79ffb4a
@hsubramanianaks
change compare branch to HEAD~1
0e77f36
@hsubramanianaks
try with main branch
868f85a
@hsubramanianaks
add echo statements to triage failure
9626fd7
@hsubramanianaks
checkout without ref
ee5d76e
@hsubramanianaks
try with github event before
699cdb1
@hsubramanianaks
put back the with ref input
4df71cb
@hsubramanianaks
try with exact commit hash
d3f8ee6
hsubramanianaks
hsubramanianaks commented Jul 28, 2023
View reviewed changes
coverage.out Outdated Show resolved Hide resolved
@hsubramanianaks hsubramanianaks marked this pull request as ready for review July 28, 2023 15:09
@hsubramanianaks
Copy link
Collaborator Author

/ok-to-test sha=3d11b9a

jaiveerk
jaiveerk requested changes Jul 28, 2023
View reviewed changes
.github/workflows/unit.yaml Outdated Show resolved Hide resolved
coverage.out Outdated Show resolved Hide resolved
@hsubramanianaks
Copy link
Collaborator Author

/ok-to-test sha=e4338bb

OliverMKing
OliverMKing previously approved these changes Jul 28, 2023
View reviewed changes
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the good work.

The badge could maybe be added to the readme.md in this PR but that's not a big deal.

@jaiveerk
Copy link
Collaborator

/ok-to-test sha=d6f1eb5

@OliverMKing OliverMKing merged commit 11ca27d into Azure:main Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaiveerk jaiveerk jaiveerk approved these changes

@OliverMKing OliverMKing OliverMKing approved these changes

@bfoley13 bfoley13 bfoley13 approved these changes

@gambtho gambtho Awaiting requested review from gambtho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hsubramanianaks @jaiveerk @bfoley13 @OliverMKing