Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding File Name and Line Number to Logs #72

Merged
merged 23 commits into from
Jul 20, 2023

Conversation

jaiveerk
Copy link
Collaborator

Description

This PR is to modify the way we construct our zap logger to include caller information in each entry

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • Unit tests have been added to ensure that the caller is present
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=8d481cd

OliverMKing
OliverMKing previously approved these changes Jul 19, 2023
@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=c76d202

1 similar comment
@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=c76d202

Copy link
Contributor

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaiveerk jaiveerk merged commit 5e28e4f into Azure:main Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants