Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap operator logger to zap json logger #69

Merged
merged 6 commits into from
Jul 14, 2023
Merged

swap operator logger to zap json logger #69

merged 6 commits into from
Jul 14, 2023

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Jul 12, 2023

Description

Swaps the operator logger to a json logger so we can more easily parse logs. Without we have to parse logs with regex which is neither efficient nor easy.

image

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally + with e2e

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=4809d70

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=b7c709d

@tbarnes94 tbarnes94 merged commit 930e6eb into Azure:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants