-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump to external dns 0.13.5 #196
Merged
OliverMKing
merged 11 commits into
Azure:main
from
OliverMKing:kingoliver/externaldnsversion
Apr 19, 2024
Merged
bump to external dns 0.13.5 #196
OliverMKing
merged 11 commits into
Azure:main
from
OliverMKing:kingoliver/externaldnsversion
Apr 19, 2024
+243
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8755854266Details
💛 - Coveralls |
/ok-to-test sha=362a538 |
/ok-to-test sha=4ee2005 |
/ok-to-test sha=4e29c80 |
aamgayle
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
jaiveerk
requested changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change requested but looks good otherwise
jaiveerk
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
bumps us to external dns 0.13.5.
Need to land on this version before jumping to higher versions because of this. This is documented by ExternalDNS.
We handle this breaking change made by ExternalDNS that will come into affect as part of this bump. We mitigate the change by using the
--txt-wildcard-replacement=approutingwildcard
flag. This makes the chance of a collision all but impossible.I also add e2e tests to cover the above wildcard case to prove it works.