Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump to external dns 0.13.5 #196

Merged
merged 11 commits into from
Apr 19, 2024
Merged

bump to external dns 0.13.5 #196

merged 11 commits into from
Apr 19, 2024

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Apr 16, 2024

Description

bumps us to external dns 0.13.5.

Need to land on this version before jumping to higher versions because of this. This is documented by ExternalDNS.

We handle this breaking change made by ExternalDNS that will come into affect as part of this bump. We mitigate the change by using the --txt-wildcard-replacement=approutingwildcard flag. This makes the chance of a collision all but impossible.

I also add e2e tests to cover the above wildcard case to prove it works.

@coveralls
Copy link
Collaborator

coveralls commented Apr 16, 2024

Pull Request Test Coverage Report for Build 8755854266

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.005%) to 80.476%

Totals Coverage Status
Change from base Build 8710719157: 0.005%
Covered Lines: 2906
Relevant Lines: 3611

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=362a538

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=4ee2005

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=4e29c80

Copy link
Contributor

@aamgayle aamgayle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor change requested but looks good otherwise

testing/e2e/infra/provision.go Show resolved Hide resolved
@OliverMKing OliverMKing merged commit 566ade4 into Azure:main Apr 19, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants