Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default nic configuration as cli args #189

Merged
merged 6 commits into from
Apr 2, 2024
Merged

add default nic configuration as cli args #189

merged 6 commits into from
Apr 2, 2024

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Apr 2, 2024

Description

Exposes default nic configuration options through cli args. There's four options

  • standard. The current experience which doesn't overwrite any LB annotations on the NIC. This is mostly used for migration purposes so we can decide when to turn on this new experience.
  • public. Forces the NIC to use a public LB
  • private. Forces the NIC to use a private LB
  • off. Doesn't reconcile the default NIC at all. Customers will be fully responsible for their NIC resource lifecyces.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Locally, unit, e2e

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Apr 2, 2024

Pull Request Test Coverage Report for Build 8526332773

Details

  • 41 of 44 (93.18%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.2%) to 80.285%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/controller.go 0 1 0.0%
pkg/controller/nginxingress/default.go 16 18 88.89%
Totals Coverage Status
Change from base Build 8513632941: 0.2%
Covered Lines: 2871
Relevant Lines: 3576

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=74eb669

Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small comment, but lgtm

@OliverMKing OliverMKing merged commit 2919a29 into Azure:main Apr 2, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants