Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump nginx to 1.10.0 #184

Merged
merged 1 commit into from
Mar 22, 2024
Merged

bump nginx to 1.10.0 #184

merged 1 commit into from
Mar 22, 2024

Conversation

OliverMKing
Copy link
Collaborator

Description

Bumps nginx to 1.10.0. Will be released tied to k8s minor version release for aks so we follow the addon breaking change policy.

https://github.com/kubernetes/ingress-nginx/releases/tag/controller-v1.10.0

The breaking changes for our customers are

  • This version dropped Opentracing and zipkin modules, just Opentelemetry is supported as of this release
  • This version dropped support for GeoIP (legacy). Only GeoIP2 is supported

This will be clearly communicated when this is released.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

e2e, unit, locally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=f0bd064

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8392385669

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 79.45%

Totals Coverage Status
Change from base Build 8391207075: 0.0%
Covered Lines: 2656
Relevant Lines: 3343

💛 - Coveralls

@OliverMKing OliverMKing merged commit 539ccb7 into Azure:main Mar 22, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants