Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding force-ssl-redirect command to crd #173

Merged
merged 61 commits into from
Apr 24, 2024

Conversation

aamgayle
Copy link
Contributor

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

aamgayle and others added 24 commits February 12, 2024 16:37
@coveralls
Copy link
Collaborator

coveralls commented Mar 14, 2024

Pull Request Test Coverage Report for Build 8790952961

Details

  • 10 of 10 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 80.514%

Totals Coverage Status
Change from base Build 8789726009: 0.04%
Covered Lines: 2913
Relevant Lines: 3618

💛 - Coveralls

@aamgayle aamgayle marked this pull request as ready for review April 4, 2024 18:47
@OliverMKing
Copy link
Collaborator

/ok-to-test sha=4c55ce4

OliverMKing
OliverMKing previously approved these changes Apr 22, 2024
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=0b3bedb

@OliverMKing OliverMKing merged commit dfdef91 into Azure:main Apr 24, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants