Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSM Functionality Updates #170

Merged
merged 33 commits into from
Mar 15, 2024
Merged

Conversation

jaiveerk
Copy link
Collaborator

Description

This modifies our resource reconciliation when OSM is enabled to avoid a unique edge case encountered during RP e2e testing where client traffic failed to get through to the downstream server due to a failing OSM injector pod.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

RP E2E, with suggestions from the OSM team.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@jaiveerk
Copy link
Collaborator Author

jaiveerk commented Mar 7, 2024

closing after issue was found to be on OSM's side, taking according internal action

@jaiveerk jaiveerk closed this Mar 7, 2024
@jaiveerk jaiveerk reopened this Mar 8, 2024
@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=e4552c0

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=081ef75

@coveralls
Copy link
Collaborator

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8297498864

Details

  • 16 of 16 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 81.258%

Totals Coverage Status
Change from base Build 8252883029: 0.006%
Covered Lines: 2558
Relevant Lines: 3148

💛 - Coveralls

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=452bb8d

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=f5d17ca

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=9c35174

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=65ebf55

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=bd3dcd5

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=5a986dc

@jaiveerk
Copy link
Collaborator Author

/ok-to-test sha=5b3cd14

Copy link
Contributor

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jaiveerk jaiveerk merged commit cf4bcca into Azure:main Mar 15, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants