Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

defaultSSLCertificate via key vault URI #166

Merged
merged 42 commits into from
Mar 27, 2024

Conversation

aamgayle
Copy link
Contributor

Description

This will allow users to set a default SSL Certificate via keyvault URI. It uses a new reconciler that watches the CRD for the addition of a keyvault URI under defaultSSLCertificate and creates and points the nginx manifest to an associated SPC afterward.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • Unit Tests
  • e2e Tests
  • testing in an actual cluster

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Feb 15, 2024

Pull Request Test Coverage Report for Build 8458009406

Details

  • 246 of 294 (83.67%) changed or added relevant lines in 7 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 80.04%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/controller.go 0 4 0.0%
pkg/controller/keyvault/kv_util.go 93 97 95.88%
api/v1alpha1/zz_generated.deepcopy.go 0 5 0.0%
pkg/controller/keyvault/ingress_secret_provider_class.go 21 26 80.77%
pkg/controller/keyvault/placeholder_pod.go 49 56 87.5%
pkg/controller/keyvault/nginx_secret_provider_class.go 76 99 76.77%
Totals Coverage Status
Change from base Build 8436857218: -0.06%
Covered Lines: 2823
Relevant Lines: 3527

💛 - Coveralls

@aamgayle aamgayle marked this pull request as ready for review February 15, 2024 15:13
api/v1alpha1/nginxingresscontroller_types.go Show resolved Hide resolved
pkg/controller/keyvault/nginx_secret_provider_class.go Outdated Show resolved Hide resolved
pkg/controller/keyvault/nginx_secret_provider_class.go Outdated Show resolved Hide resolved
pkg/controller/keyvault/placeholder_pod.go Outdated Show resolved Hide resolved
pkg/controller/keyvault/placeholder_pod.go Outdated Show resolved Hide resolved
pkg/controller/keyvault/placeholder_pod.go Outdated Show resolved Hide resolved
pkg/controller/keyvault/placeholder_pod.go Outdated Show resolved Hide resolved
pkg/controller/nginxingress/nginx_ingress_controller.go Outdated Show resolved Hide resolved
testing/e2e/suites/nginxIngressController.go Show resolved Hide resolved
api/v1alpha1/nginxingresscontroller_types.go Outdated Show resolved Hide resolved
@aamgayle aamgayle requested a review from OliverMKing February 26, 2024 17:09
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work!

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=3e66697

@aamgayle aamgayle merged commit ef0b85a into Azure:main Mar 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants