-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defaultSSLCertificate via key vault URI #166
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8458009406Details
💛 - Coveralls |
OliverMKing
reviewed
Feb 15, 2024
OliverMKing
requested changes
Feb 15, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Feb 26, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
reviewed
Mar 27, 2024
OliverMKing
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work!
/ok-to-test sha=3e66697 |
bfoley13
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will allow users to set a default SSL Certificate via keyvault URI. It uses a new reconciler that watches the CRD for the addition of a keyvault URI under defaultSSLCertificate and creates and points the nginx manifest to an associated SPC afterward.
Fixes # (issue)
Feature # (details)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?
Checklist: