Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating Base Image to Use Distroless #164

Merged
merged 1 commit into from
Feb 7, 2024

Conversation

jaiveerk
Copy link
Collaborator

@jaiveerk jaiveerk commented Feb 6, 2024

Description

Updating our base image to use OSS static distroless image instead of scratch. This image runs with a specific UID we can configure our podsecuritycontext with. This gives us explicit control over file and process ownership and allows us to safely mount a homedir/filesystem that can be used for caching and other purposes.

Fixes # (issue)
Feature # (details)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration. Is it a breaking change which will impact consuming tool(s)?

  • e2e

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 7806946932

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.252%

Totals Coverage Status
Change from base Build 7789109122: 0.0%
Covered Lines: 2557
Relevant Lines: 3147

💛 - Coveralls

@Tatsinnit Tatsinnit added the enhancement New feature or request label Feb 6, 2024
Copy link
Collaborator

@OliverMKing OliverMKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@OliverMKing
Copy link
Collaborator

/ok-to-test sha=cd23800

@jaiveerk jaiveerk merged commit 1cf0067 into Azure:main Feb 7, 2024
9 checks passed
@jaiveerk jaiveerk deleted the jkatariya/update-base-image branch February 7, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants