-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove webhook logic #151
Merged
OliverMKing
merged 8 commits into
Azure:main
from
OliverMKing:kingoliver/cleanupwebhook
Jan 11, 2024
Merged
remove webhook logic #151
OliverMKing
merged 8 commits into
Azure:main
from
OliverMKing:kingoliver/cleanupwebhook
Jan 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7492015651
💛 - Coveralls |
/ok-to-test sha=d3ab53a |
1 similar comment
/ok-to-test sha=d3ab53a |
/ok-to-test sha=7a1fcc5 |
/ok-to-test sha=e79ad1c |
bfoley13
previously approved these changes
Jan 11, 2024
jaiveerk
reviewed
Jan 11, 2024
jaiveerk
previously approved these changes
Jan 11, 2024
/ok-to-test sha=7a758be |
/ok-to-test sha=b8d80b7 |
jaiveerk
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cleans up webhook related code in favor of crd yaml based validation. Reduces complexity significantly. Need to be testing the non webhook version in e2e which this pr accomplishes.
No need to keep tech debt of webhook code when we aren't planning on using them short term.
Also improves our e2e pass rate significantly with this pr. Improves a few different aspects that have been a bit flaky.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
e2e, unit, and manually
Checklist: