Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove webhook logic #151

Merged
merged 8 commits into from
Jan 11, 2024
Merged

remove webhook logic #151

merged 8 commits into from
Jan 11, 2024

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Jan 9, 2024

Description

cleans up webhook related code in favor of crd yaml based validation. Reduces complexity significantly. Need to be testing the non webhook version in e2e which this pr accomplishes.

No need to keep tech debt of webhook code when we aren't planning on using them short term.

Also improves our e2e pass rate significantly with this pr. Improves a few different aspects that have been a bit flaky.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

e2e, unit, and manually

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Jan 9, 2024

Pull Request Test Coverage Report for Build 7492015651

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.0%) to 81.957%

Totals Coverage Status
Change from base Build 7465434181: 1.0%
Covered Lines: 2530
Relevant Lines: 3087

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=d3ab53a

1 similar comment
@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=d3ab53a

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=7a1fcc5

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=e79ad1c

bfoley13
bfoley13 previously approved these changes Jan 11, 2024
jaiveerk
jaiveerk previously approved these changes Jan 11, 2024
@OliverMKing OliverMKing dismissed stale reviews from jaiveerk and bfoley13 via 7a758be January 11, 2024 16:43
@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=7a758be

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=b8d80b7

@OliverMKing OliverMKing merged commit 5cd39ec into Azure:main Jan 11, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants