add yaml-based crd validation + defaults #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Angry unit tests. Will figure out why tomorrow |
jaiveerk
previously approved these changes
Jan 9, 2024
jaiveerk
reviewed
Jan 9, 2024
| @@ -146,7 +153,8 @@ type NginxIngressController struct { | |||
| metav1.ObjectMeta `json:"metadata,omitempty"` | |||
|
|
|||
| // +required | |||
| Spec NginxIngressControllerSpec `json:"spec,omitempty"` | |||
| // +kubebuilder:default:={"ingressClassName":"nginx.approuting.kubernetes.azure.com","controllerNamePrefix":"nginx"} | |||
There was a problem hiding this comment.
is there any way we can validate that this inline json string is properly formatted? it looks fine, but just wondering more from a theoretical standpoint
There was a problem hiding this comment.
If this string is malformed our e2e runner will fail because the crd won't be able to be applied.
CRDs validate this when they are applied against the k8s api server.
I know because this happened to me when I made a typo in an earlier iteration of this PR.
Pull Request Test Coverage Report for Build 7464140143
💛 - Coveralls |
|
/ok-to-test sha=7c5e5de |
bfoley13
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds yaml-based crd validation to our crd. Reduces the need for webhooks (makes it more acceptable to not use webhooks which add lots of overhead).
Will clean up some old stuff that's not needed anymore in the next PR (and add some stuff to our e2e runner).
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested locally and e2e tested.
Checklist: