Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

always reconcile default nic #138

Merged
merged 2 commits into from
Nov 21, 2023
Merged

always reconcile default nic #138

merged 2 commits into from
Nov 21, 2023

Conversation

OliverMKing
Copy link
Collaborator

Description

Switches operator logic to always create / ensure the default nic exists. The previous model only ensured the default nic when a user was previously using app routing (the upgrade scenario).

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tested and tested locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=3157ea4

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=f71574c

@coveralls
Copy link
Collaborator

coveralls commented Nov 20, 2023

Pull Request Test Coverage Report for Build 6935864422

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 78.788%

Totals Coverage Status
Change from base Build 6908751951: 0.01%
Covered Lines: 2886
Relevant Lines: 3663

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=f71574c

Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@OliverMKing OliverMKing merged commit 198fdc9 into Azure:main Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants