Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch all controllers to use crd as source of truth #128

Merged
merged 7 commits into from
Nov 8, 2023
Merged

switch all controllers to use crd as source of truth #128

merged 7 commits into from
Nov 8, 2023

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Nov 8, 2023

Description

Switches the crd to be the source of truth for all controllers.

TODO next pr: push event to crd if fail to reconcile

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally and unit tested

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing OliverMKing changed the title Kingoliver/dynamic6 switch all controllers to use crd as source of truth Nov 8, 2023
@coveralls
Copy link
Collaborator

coveralls commented Nov 8, 2023

Pull Request Test Coverage Report for Build 6801242937

  • 139 of 210 (66.19%) changed or added relevant lines in 9 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.04%) to 77.007%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/keyvault/placeholder_pod.go 2 4 50.0%
pkg/controller/ingress/concurrency_watchdog.go 32 35 91.43%
pkg/controller/nginxingress/nginx_ingress_controller.go 23 28 82.14%
pkg/controller/nginxingress/index.go 43 60 71.67%
pkg/controller/controller.go 0 44 0.0%
Files with Coverage Reduction New Missed Lines %
pkg/controller/nginxingress/nginx_ingress_controller.go 1 68.59%
pkg/controller/controller.go 2 17.22%
Totals Coverage Status
Change from base Build 6758002808: -0.04%
Covered Lines: 2763
Relevant Lines: 3588

💛 - Coveralls

@OliverMKing OliverMKing merged commit d4d5ae2 into Azure:main Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants