-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
apply crds on operator startup #122
Conversation
Pull Request Test Coverage Report for Build 6711524321
💛 - Coveralls |
@@ -96,9 +75,3 @@ func TestGetSelfDeploy(t *testing.T) { | |||
require.Nil(t, self) | |||
}) | |||
} | |||
|
|||
func TestNewManagerForRestConfig(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't test things that use the utils.upsert function with the fake environment. That's fine. NewManagerForRestConfig is essentially the main function and doesn't have any logic by itself. Isn't valuable to unit test in the first place.
This will be covered by all e2e tests as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor change but lgtm
Description
Applies the crds on operator startup, crashes the operator if it can't do that.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Unit and manually. Will be e2e tested with future additions since tests will rely on crds which will rely on the definition being in the cluster.
Checklist: