Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nginxingresscontroller crd #121

Merged
merged 3 commits into from
Oct 31, 2023
Merged

add nginxingresscontroller crd #121

merged 3 commits into from
Oct 31, 2023

Conversation

OliverMKing
Copy link
Collaborator

Description

Adds the nginx ingress controller crd

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Unit tested. Nothing here changes the behavior of operator yet so no e2e tests yet.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Oct 30, 2023

Pull Request Test Coverage Report for Build 6707619501

  • 71 of 157 (45.22%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-2.7%) to 86.25%

Changes Missing Coverage Covered Lines Changed/Added Lines %
api/v1alpha1/zz_generated.deepcopy.go 0 86 0.0%
Totals Coverage Status
Change from base Build 6671581685: -2.7%
Covered Lines: 2139
Relevant Lines: 2480

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=4a68079

PROJECT Show resolved Hide resolved
Copy link
Member

@bfoley13 bfoley13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me but you might have someone from another team whos built out CRD's take a look as well

Copy link
Collaborator

@jaiveerk jaiveerk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small changes but lgtm

Makefile Show resolved Hide resolved
api/v1alpha1/nginxingresscontroller_types.go Show resolved Hide resolved
@OliverMKing OliverMKing merged commit d6fd174 into Azure:main Oct 31, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants