Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve logging #110

Merged
merged 3 commits into from
Oct 11, 2023
Merged

improve logging #110

merged 3 commits into from
Oct 11, 2023

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Oct 9, 2023

Description

Improves logging in our controllers

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

E2e and unit

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@coveralls
Copy link
Collaborator

coveralls commented Oct 9, 2023

Pull Request Test Coverage Report for Build 6483628626

  • 80 of 91 (87.91%) changed or added relevant lines in 8 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 88.835%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/controller/osm/ingress_cert_config_reconciler.go 9 10 90.0%
pkg/controller/keyvault/placeholder_pod.go 11 13 84.62%
pkg/controller/ingress/concurrency_watchdog.go 15 18 83.33%
pkg/controller/keyvault/event_mirror.go 23 28 82.14%
Files with Coverage Reduction New Missed Lines %
pkg/controller/keyvault/event_mirror.go 1 88.89%
Totals Coverage Status
Change from base Build 6434739717: 0.1%
Covered Lines: 2029
Relevant Lines: 2284

💛 - Coveralls

davidgamero
davidgamero previously approved these changes Oct 10, 2023
Copy link
Contributor

@davidgamero davidgamero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=996e000

@OliverMKing OliverMKing merged commit ab62c41 into Azure:main Oct 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants