Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add retry to build acr image e2e #104

Merged
merged 11 commits into from
Sep 27, 2023
Merged

add retry to build acr image e2e #104

merged 11 commits into from
Sep 27, 2023

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Sep 27, 2023

Description

Adds a retry on acr image build in e2e. This fixes a random error that started appearing yesterday where e2e occasionally says it can't find the acr in the subscription on an acr build.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Local e2e

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=54ea497

@coveralls
Copy link
Collaborator

coveralls commented Sep 27, 2023

Pull Request Test Coverage Report for Build 6330958163

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.718%

Totals Coverage Status
Change from base Build 6330724554: 0.0%
Covered Lines: 1966
Relevant Lines: 2216

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=b14624c

@OliverMKing OliverMKing changed the title add resource group flag to acr build e2e add retry to build acr image e2e Sep 27, 2023
@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=970cdb3

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=9ebfb69

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=e625e15

2 similar comments
@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=e625e15

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=e625e15

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=83c74dc

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=5ee961a

@OliverMKing OliverMKing merged commit f5bfd2c into Azure:main Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants