remove resource limit on nginx ingress controller and add topology spread #103
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removes the resource limit on the nginx ingress controller. This allows for app routing to work on clusters with many cpus. NGINX automatically scales worker processes based on node cpus.
We also change the HPA to scale slightly more aggressively. This should lower the amount of CPU used by a single nginx ingress controller replica which means that the actual usage should be more in-line with the Resource Requests (which is good because it's guaranteed).
Pod topology spread ensures nginx ingress controller scheduled on different nodes when possible. Helps avoid single Node failure taking down the Ingress.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Tested on e2e and locally.
Checklist: