Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove resource limit on nginx ingress controller and add topology spread #103

Closed
wants to merge 4 commits into from
Closed

remove resource limit on nginx ingress controller and add topology spread #103

wants to merge 4 commits into from

Conversation

OliverMKing
Copy link
Collaborator

@OliverMKing OliverMKing commented Sep 26, 2023

Description

Removes the resource limit on the nginx ingress controller. This allows for app routing to work on clusters with many cpus. NGINX automatically scales worker processes based on node cpus.

We also change the HPA to scale slightly more aggressively. This should lower the amount of CPU used by a single nginx ingress controller replica which means that the actual usage should be more in-line with the Resource Requests (which is good because it's guaranteed).

Pod topology spread ensures nginx ingress controller scheduled on different nodes when possible. Helps avoid single Node failure taking down the Ingress.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested on e2e and locally.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@OliverMKing OliverMKing changed the title remove resource limit on nginx ingress controller remove resource limit on nginx ingress controller and add topology spread Sep 26, 2023
@coveralls
Copy link
Collaborator

coveralls commented Sep 26, 2023

Pull Request Test Coverage Report for Build 6339759755

  • 52 of 52 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 88.789%

Totals Coverage Status
Change from base Build 6331531917: 0.07%
Covered Lines: 1980
Relevant Lines: 2230

💛 - Coveralls

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=386513c

1 similar comment
@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=386513c

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=386513c

@OliverMKing
Copy link
Collaborator Author

/ok-to-test sha=1da477d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants