Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

revert swarmm change #3995

Merged
merged 1 commit into from
Oct 11, 2018
Merged

revert swarmm change #3995

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parts/swarm/swarmmastervars.t
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
]
],
{{if .OrchestratorProfile.IsSwarmMode}}
"orchestratorName": "swarm",
"orchestratorName": "swarmm",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is only used to name resources, can we make it swarrmmode for clarity?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"swarmm" just looks like a spelling mistake which is what tricked you into changing it the first time

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preference for not making a change

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tricked me actually.

"masterOSImageOffer": {{GetMasterOSImageOffer}},
"masterOSImagePublisher": {{GetMasterOSImagePublisher}},
"masterOSImageSKU": {{GetMasterOSImageSKU}},
Expand Down