Output VMSS cloud config settings. #3610
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: JunSun17 If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3610 +/- ##
==========================================
+ Coverage 55.4% 55.45% +0.04%
==========================================
Files 107 107
Lines 16210 16210
==========================================
+ Hits 8981 8989 +8
+ Misses 6453 6445 -8
Partials 776 776 |
|
@JunSun17 What's the functional purpose of this change? |
parts/iaasoutputs.t
Outdated
| "type": "string", | ||
| "value": "[variables('primaryScaleSetName')]" | ||
| }, | ||
| "vmType": { |
There was a problem hiding this comment.
This change is originally target to pass the cloud config settings of vmType and primaryScaleSetName to AKS (in the way of exposing it to ARM output). This is the way we used to pass all cloud provider config settings.
I will see if we can build these strings in AKS for its cloud provider config.
| @@ -359,11 +359,11 @@ | |||
| "nsgID": "[resourceId('Microsoft.Network/networkSecurityGroups',variables('nsgName'))]", | |||
| {{if not AnyAgentUsesVirtualMachineScaleSets}} | |||
| "primaryAvailabilitySetName": "[concat('{{ (index .AgentPoolProfiles 0).Name }}-availabilitySet-',variables('nameSuffix'))]", | |||
| "primaryScaleSetName": "''", | |||
| "primaryScaleSetName": "", | |||
There was a problem hiding this comment.
What is the purpose of these changes (from literal '' to empty string)?
There was a problem hiding this comment.
If it is set to "''", it will not be an empty string in the output. the output will be ''. We need an empty string as the result.
Output VMSS cloud config settings for AKS to consume.