This repository was archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 558
Kubernetes: acceleratedNetworking as a static whitelist #3600
Merged
jackfrancis
merged 2 commits into
Azure:master
from
jackfrancis:accelerated-networking-blacklist
Aug 2, 2018
Merged
Kubernetes: acceleratedNetworking as a static whitelist #3600
jackfrancis
merged 2 commits into
Azure:master
from
jackfrancis:accelerated-networking-blacklist
Aug 2, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Temporary workaround:
|
Codecov Report
@@ Coverage Diff @@
## master #3600 +/- ##
=========================================
- Coverage 55.63% 55.6% -0.04%
=========================================
Files 107 107
Lines 16192 16172 -20
=========================================
- Hits 9008 8992 -16
- Misses 6423 6428 +5
+ Partials 761 752 -9 |
CecileRobertMichon
approved these changes
Aug 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon, jackfrancis The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Standard_DS2, Standard_E2s_v3, Standard_F2s_v2 are complaining about not having accelerated networking support from our production data.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: