This repository was archived by the owner on Jan 11, 2023. It is now read-only.
Replace Glide with Golang Dep #3522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3522 +/- ##
==========================================
- Coverage 55.49% 55.47% -0.02%
==========================================
Files 105 105
Lines 15990 15990
==========================================
- Hits 8873 8871 -2
- Misses 6369 6370 +1
- Partials 748 749 +1 |
|
Are we not going to keep deps in |
|
@cpuguy83 Yes, no change to that strategy, just a change of tool. |
jackfrancis
approved these changes
Jul 20, 2018
|
I'm not sure I understand. |
|
Yeah, I thought that too, it's that github is truncating the diff and sorting by deletes. dep does seem to be conspicuously culling a ton of (seemingly non-used) |
jackfrancis
pushed a commit
that referenced
this pull request
Jul 20, 2018
# Conflicts: # docs/developers.md
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Glide is deprecated and suggesting its users move to Golang dep.
fixes #3454