This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Add keyvault-flexvolume addon #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
Codecov Report
@@ Coverage Diff @@
## master #3498 +/- ##
==========================================
- Coverage 55.89% 55.86% -0.03%
==========================================
Files 105 105
Lines 15943 15989 +46
==========================================
+ Hits 8911 8932 +21
- Misses 6282 6309 +27
+ Partials 750 748 -2 |
jackfrancis
reviewed
Jul 18, 2018
| addonmanager.kubernetes.io/mode: "EnsureExists" | ||
| spec: | ||
| tolerations: | ||
| containers: |
There was a problem hiding this comment.
Should we add resource limits?
jackfrancis
approved these changes
Jul 18, 2018
There was a problem hiding this comment.
Added a comment about resource limits, otherwise lgtm
Thanks @ritazh!
ritazh
force-pushed
the
feat-kvflexvolume
branch
from
5a5cd6f to
44f3870
Compare
jackfrancis
approved these changes
Jul 19, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR enables the new keyvault-flexvolume addon. With the Azure Key Vault FlexVolume, developers can access application-specific secrets, keys, and certs stored in Azure Key Vault directly from their pods.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
If applicable:
Release note: