This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
NVIDIA device plugin limits and requests #3497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Thank you @sozercan! |
ritazh
reviewed
Jul 18, 2018
| @@ -975,6 +975,30 @@ func (t *TemplateGenerator) getTemplateFuncMap(cs *api.ContainerService) templat | |||
| } else { | |||
| val = cloudSpecConfig.KubernetesSpecConfig.NVIDIAImageBase + KubeConfigs[k8sVersion][NVIDIADevicePluginAddonName] | |||
| } | |||
| case "kubernetesNVIDIADevicePluginCPURequests": | |||
| if aC > -1 { | |||
There was a problem hiding this comment.
I think this should be nC, instead of aC.
nC := getAddonContainersIndexByName(nvidiaDevicePluginAddon.Containers, NVIDIADevicePluginAddonName)
There was a problem hiding this comment.
indeed, will file a quick fix, good find!
ritazh
reviewed
Jul 19, 2018
| @@ -40,6 +40,13 @@ spec: | |||
| containers: | |||
| - image: <kubernetesNVIDIADevicePluginSpec> | |||
| name: nvidia-device-plugin-ctr | |||
There was a problem hiding this comment.
This name needs to match NVIDIADevicePluginAddonName, which should be nvidia-device-plugin
There was a problem hiding this comment.
i think we can just change the name here to nvidia-device-plugin
kkmsft
pushed a commit
to kkmsft/acs-engine
that referenced
this pull request
Jul 20, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #3481