Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Remove FQDNSuffix #3486

Merged
merged 1 commit into from
Jul 17, 2018
Merged

Remove FQDNSuffix #3486

merged 1 commit into from
Jul 17, 2018

Conversation

karataliu
Copy link
Contributor

What this PR does / why we need it:
Remove FQDNSuffix since not used after #2354

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

If applicable:

  • documentation
  • unit tests
  • tested backward compatibility (ie. deploy with previous version, upgrade with this branch)

Release note:

@jackfrancis
Copy link
Member

@CecileRobertMichon to lgtm

@codecov
Copy link

codecov bot commented Jul 17, 2018

Codecov Report

Merging #3486 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3486   +/-   ##
=======================================
  Coverage   55.94%   55.94%           
=======================================
  Files         105      105           
  Lines       15917    15917           
=======================================
  Hits         8905     8905           
  Misses       6262     6262           
  Partials      750      750

Copy link
Contributor

@CecileRobertMichon CecileRobertMichon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CecileRobertMichon CecileRobertMichon merged commit 0706073 into Azure:master Jul 17, 2018
@karataliu karataliu deleted the rm_fqdnsuffix branch July 18, 2018 02:18
kkmsft pushed a commit to kkmsft/acs-engine that referenced this pull request Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants